Add active launch indicator to launch history menu by SougandhS · Pull Request #2652 · eclipse-platform/eclipse.platform

SougandhS · 2026-05-05T12:46:55Z

Adds support to show an active launch indicator in the launch history menu, helping users quickly identify which launch configurations are currently running from launch history. Entries with associated non-terminated launches are marked with a visual indicator "●" ,Once the indicator is shown, users can immediately recognize that the configuration is already running, helping avoid unnecessary or unintended clicks from the launch history menu. The feature is controlled by the preference

and is applied only when enabled, ensuring no change to existing behavior by default.

With Active (Running)

With In-Active (Terminated or not launched)

iloveeclipse · 2026-05-05T12:50:54Z

Since recently the "circle" was added to indicate changed file, I would not use this for running launch config, it would be confusing.

What about simple "(running)" label?

SougandhS · 2026-05-05T12:54:41Z

What about simple "(running)" label?

I went with this first, but It felt bit long...

SougandhS · 2026-05-05T12:57:22Z

Since recently the "circle" was added to indicate changed file, I would not use this for running launch config, it would be confusing.

How about \u25B8 ?

iloveeclipse · 2026-05-05T13:45:15Z

How about \u25B8 ?

How about \u2699 ( ⚙ "gear" ) or \u1F3C3 ( 🏃 "running man" ) ?

SougandhS · 2026-05-05T13:55:03Z

How about \u2699 ( ⚙ "gear" ) or \u1F3C3 ( 🏃 "running man" ) ?

Gear looks great !

Pushed this change

\u1F3C3 ( 🏃 "running man" )

this doesn't render 😅

iloveeclipse · 2026-05-05T14:01:07Z

The change is simple and nice, do we really need an option for that? If yes, please enable by default.

iloveeclipse · 2026-05-05T14:02:50Z

+		ILaunch[] launches = DebugPlugin.getDefault().getLaunchManager().getLaunches();
+		IPreferenceStore store = DebugUIPlugin.getDefault().getPreferenceStore();
+		boolean launchPref = store.getBoolean(IInternalDebugUIConstants.PREF_LAUNCHED_INDICATOR);
 		for (ILaunchConfiguration launch : favoriteList) {


Can you please guard the new code, including fetching of the launch configs by first check if launchPref is set? Same below.

Added a length check for launches

This check is not needed, the checkIfLaunched() will not do much if it is empty, same below

akurtakov · 2026-05-05T14:06:53Z

If unicode symbol is to be used - extra testing is needed that the chosen one is widely available in default fonts as per (https://eclipse.dev/eclipse/development/plans/eclipse_project_plan_4_40.xml#target_environments) and ideally in some popular fonts(whatever they are) and last but not least verify on all platform that nothing bad happens when a font that doesn't contain the symbol is used.

akurtakov · 2026-05-05T14:08:09Z

The change is simple and nice, do we really need an option for that? If yes, please enable by default.

Please no option for such things. We already have more options than one can find and manage.

SougandhS · 2026-05-05T14:17:51Z

The change is simple and nice, do we really need an option for that? If yes, please enable by default.

Please no option for such things. We already have more options than one can find and manage.

Removed all the preference parts 👍

SougandhS · 2026-05-05T14:23:52Z

If unicode symbol is to be used - extra testing is needed that the chosen one is widely available in default fonts as per (https://eclipse.dev/eclipse/development/plans/eclipse_project_plan_4_40.xml#target_environments) and ideally in some popular fonts(whatever they are) and last but not least verify on all platform that nothing bad happens when a font that doesn't contain the symbol is used.

Thanks, I'll try to check in these platforms..

iloveeclipse · 2026-05-05T14:28:52Z

If unicode symbol is to be used - extra testing is needed that the chosen one is widely available in default fonts

See also https://stackoverflow.com/questions/48468088/unicode-character-uncompatibility

At least on RHEL 9.6 with "Sans Serif" dialog font (whatever system means with that name) it looks OK.

github-actions · 2026-05-05T15:06:50Z

Test Results

54 files ±0 54 suites ±0 37m 54s ⏱️ + 1m 48s
4 665 tests ±0 4 643 ✅ ±0 22 💤 ±0 0 ❌ ±0
12 435 runs ±0 12 279 ✅ ±0 156 💤 ±0 0 ❌ ±0

Results for commit a752103. ± Comparison against base commit b1b8226.

♻️ This comment has been updated with latest results.

SougandhS · 2026-05-06T05:59:42Z

Hi @iloveeclipse, @akurtakov, how about adding overlay image ?

iloveeclipse · 2026-05-06T06:38:30Z

how about adding overlay image ?

Why not, but then maybe the one with the green "Run" arrow like on the Progress view icon?

akurtakov · 2026-05-06T07:40:09Z

I have a preference to (widely spread) unicode symbol as (at least on Linux) these autoadjust contrast on changes of Gtk theme. Also they are less resource hungry and auto managed by OS instead of images that have to be destroyed and etc.

iloveeclipse · 2026-05-06T08:20:21Z

So let's try with \u2699 ( ⚙ "gear" ) and push it to M3 so hopefully more people could test it. If someone complains, we can switch it off for RC.

SougandhS · 2026-05-06T09:59:34Z

So let's try with \u2699 ( ⚙ "gear" ) and push it to M3 so hopefully more people could test it. If someone complains, we can switch it off for RC.

So include a preference option ?

iloveeclipse · 2026-05-06T10:14:06Z

no, just merge & check for bug reports. worst case is some rectangle shown instead I assume.

Adds a visual indicator to launch configurations that are currently active in the launch history menu.

iloveeclipse · 2026-05-06T10:49:41Z

+	 */
+	private boolean checkIfLaunched(ILaunchConfiguration launchConfiguration, ILaunch[] launches) {
+		for (ILaunch launch : launches) {
+			if (launch.getLaunchConfiguration().equals(launchConfiguration) && !launch.isTerminated()) {


launch.getLaunchConfiguration() can be null

iloveeclipse · 2026-05-06T10:50:29Z

 		for (ILaunchConfiguration launch : historyList) {
 			LaunchAction action= new LaunchAction(launch, getMode());
+			if (launches.length > 0 && checkIfLaunched(launch, launches)) {
+				action.setText(action.getText() + "  \u2699"); //$NON-NLS-1$


Are two spaces between text and new character intended?

Yes two spaces are required. else it wont look good

iloveeclipse · 2026-05-06T10:56:51Z

+		ILaunch[] launches = DebugPlugin.getDefault().getLaunchManager().getLaunches();
+		IPreferenceStore store = DebugUIPlugin.getDefault().getPreferenceStore();
+		boolean launchPref = store.getBoolean(IInternalDebugUIConstants.PREF_LAUNCHED_INDICATOR);
 		for (ILaunchConfiguration launch : favoriteList) {


This check is not needed, the checkIfLaunched() will not do much if it is empty, same below

Copilot

Pull request overview

Adds UI decoration to the launch history (favorites + history) drop-down menu so that entries corresponding to a currently active (non-terminated) launch are visually marked, helping users avoid relaunching already-running configurations.

Changes:

Fetches current launches from the launch manager when building the launch history menu.
Decorates matching launch history/favorite entries by appending a Unicode indicator.
Introduces a helper method to detect whether a configuration has an associated non-terminated launch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	 */
+	private boolean checkIfLaunched(ILaunchConfiguration launchConfiguration, ILaunch[] launches) {
+		for (ILaunch launch : launches) {
+			if (launch.getLaunchConfiguration().equals(launchConfiguration) && !launch.isTerminated()) {


+		ILaunch[] launches = DebugPlugin.getDefault().getLaunchManager().getLaunches();
 		for (ILaunchConfiguration launch : favoriteList) {
 			LaunchAction action= new LaunchAction(launch, getMode());
+			if (launches.length > 0 && checkIfLaunched(launch, launches)) {
+				action.setText(action.getText() + "  \u2699"); //$NON-NLS-1$
+			}
 			addToMenu(menu, action, accelerator);
 			accelerator++;
 		}

 		// Separator between favorites and history
 		if (favoriteList.length > 0 && historyList.length > 0) {
 			addSeparator(menu);
 		}

 		// Add history launches next
 		for (ILaunchConfiguration launch : historyList) {
 			LaunchAction action= new LaunchAction(launch, getMode());
+			if (launches.length > 0 && checkIfLaunched(launch, launches)) {
+				action.setText(action.getText() + "  \u2699"); //$NON-NLS-1$
+			}


+	/**
+	 * Returns whether the given launch configuration has been launched.
+	 *
+	 * @param launchConfiguration the launch configuration
+	 * @param launches            the current active launches
+	 * @return {@code true} if a matching launch exists, {@code false} otherwise
+	 */
+	private boolean checkIfLaunched(ILaunchConfiguration launchConfiguration, ILaunch[] launches) {
+		for (ILaunch launch : launches) {
+			if (launch.getLaunchConfiguration().equals(launchConfiguration) && !launch.isTerminated()) {
+				return true;
+			}
+		}
+		return false;


 	protected void fillMenu(Menu menu) {
 		ILaunchConfiguration[] historyList= getHistory();
 		ILaunchConfiguration[] favoriteList = getFavorites();

 		// Add favorites
 		int accelerator = 1;
+		ILaunch[] launches = DebugPlugin.getDefault().getLaunchManager().getLaunches();
 		for (ILaunchConfiguration launch : favoriteList) {
 			LaunchAction action= new LaunchAction(launch, getMode());
+			if (launches.length > 0 && checkIfLaunched(launch, launches)) {
+				action.setText(action.getText() + "  \u2699"); //$NON-NLS-1$
+			}
 			addToMenu(menu, action, accelerator);
 			accelerator++;
 		}

 		// Separator between favorites and history
 		if (favoriteList.length > 0 && historyList.length > 0) {
 			addSeparator(menu);
 		}

 		// Add history launches next
 		for (ILaunchConfiguration launch : historyList) {
 			LaunchAction action= new LaunchAction(launch, getMode());
+			if (launches.length > 0 && checkIfLaunched(launch, launches)) {
+				action.setText(action.getText() + "  \u2699"); //$NON-NLS-1$
+			}
 			addToMenu(menu, action, accelerator);
 			accelerator++;
 		}


SougandhS force-pushed the LaunchActive branch from 20a1b95 to f9a6db6 Compare May 5, 2026 13:54

iloveeclipse reviewed May 5, 2026

View reviewed changes

SougandhS force-pushed the LaunchActive branch 2 times, most recently from 18c45c7 to e2949db Compare May 5, 2026 14:16

Add active launch indicator to launch history menu

a752103

Adds a visual indicator to launch configurations that are currently active in the launch history menu.

SougandhS force-pushed the LaunchActive branch from e2949db to a752103 Compare May 6, 2026 10:16

iloveeclipse reviewed May 6, 2026

View reviewed changes

iloveeclipse requested a review from Copilot May 6, 2026 10:57

Copilot started reviewing on behalf of iloveeclipse May 6, 2026 10:58 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Conversation

SougandhS commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iloveeclipse commented May 5, 2026

Uh oh!

SougandhS commented May 5, 2026

Uh oh!

SougandhS commented May 5, 2026

Uh oh!

iloveeclipse commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SougandhS commented May 5, 2026

Uh oh!

iloveeclipse commented May 5, 2026

Uh oh!

iloveeclipse May 5, 2026

Choose a reason for hiding this comment

Uh oh!

SougandhS May 5, 2026

Choose a reason for hiding this comment

Uh oh!

iloveeclipse May 6, 2026

Choose a reason for hiding this comment

Uh oh!

akurtakov commented May 5, 2026

Uh oh!

akurtakov commented May 5, 2026

Uh oh!

SougandhS commented May 5, 2026

Uh oh!

SougandhS commented May 5, 2026

Uh oh!

iloveeclipse commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

SougandhS commented May 6, 2026

Uh oh!

iloveeclipse commented May 6, 2026

Uh oh!

akurtakov commented May 6, 2026

Uh oh!

iloveeclipse commented May 6, 2026

Uh oh!

SougandhS commented May 6, 2026

Uh oh!

iloveeclipse commented May 6, 2026

Uh oh!

iloveeclipse May 6, 2026

Choose a reason for hiding this comment

Uh oh!

iloveeclipse May 6, 2026

Choose a reason for hiding this comment

Uh oh!

SougandhS May 6, 2026

Choose a reason for hiding this comment

Uh oh!

iloveeclipse May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SougandhS commented May 5, 2026 •

edited

Loading

iloveeclipse commented May 5, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading